Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-1100 release prep #1387

Merged
merged 2 commits into from
Nov 25, 2024
Merged

runtime-1100 release prep #1387

merged 2 commits into from
Nov 25, 2024

Conversation

Dinonard
Copy link
Member

Release prep for runtime-1100 release.

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Nov 25, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
precompiles/assets-erc20/src 78% 0%
pallets/vesting-mbm/src 89% 0%
chain-extensions/types/assets/src 0% 0%
pallets/static-price-provider/src 85% 0%
precompiles/dapp-staking/src/test 0% 0%
pallets/unified-accounts/src 86% 0%
pallets/dapp-staking/src 83% 0%
pallets/inflation/src 89% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
precompiles/xcm/src 71% 0%
primitives/src/xcm 65% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/ethereum-checked/src 74% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/sr25519/src 64% 0%
pallets/collator-selection/src 92% 0%
primitives/src 57% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/collective-proxy/src 86% 0%
pallets/price-aggregator/src 82% 0%
pallets/xc-asset-config/src 50% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking/src/test 0% 0%
precompiles/dapp-staking/src 90% 0%
Summary 79% (3730 / 4738) 0% (0 / 0)

Minimum allowed line rate is 50%

@@ -1,6 +1,6 @@
[package]
name = "astar-runtime"
version = "5.45.0"
version = "5.46.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove versioning from runtime now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Also, perhaps a topic for another PR/discussion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't need it. How do we bump it anyway

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now it looks like it's connected to client release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions are still "aligned", that's true, but they are not connected.

The bump is in respect to the crate level, same as until now I guess?
Breaking changes or new major updates would entail major version bump, otherwise minor or patch where appropriate.

Just my opinion - but wouldn't it be weird to release new versions of a "crate", while keeping the crate version same?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can align it with spec. 1.10.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, it would have to be 1.11.0 then 🙂. The last two digits are patch version, the first two (or more) are a combination of major/minor version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in, we can use 1.11.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I meant to write 11.0.0 🤦 . But let's keep in mind that we're on 5.x.y now, and going back to 1 as major version would be weird.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that our runtime release format is XXYY, what would the version be for a minor runtime release like 1101? Would it be 11.1.0? I assume the patch digit would always remain 0 in that case

Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard merged commit 1107fa7 into master Nov 25, 2024
12 checks passed
@Dinonard Dinonard deleted the feat/runtime-1100-release-prep branch November 25, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants